Use modern techniques to delete copy constructors and assignment operators by leekillough · Pull Request #1233 · sstsimulator/sst-core

leekillough · 2025-03-06T01:11:42Z

This uses modern methods of deleting copy constructors and copy assignment operators, with = delete.

Copy assignment operators declared void operator=() were changed to class& operator=() to become a copy assignment operator as defined by the language, so that the default one can be deleted.

For some classes, a default constructor previously explicitly declared private to prevent its use outside of the class was removed, because the declaration of the copy constructor causes the deletion of the default constructor.

github-actions · 2025-03-06T01:12:04Z

CLANG-FORMAT TEST - FAILED (on last commit):
Run > ./scripts/clang-format-test.sh using clang-format v12 to check formatting

github-actions · 2025-03-06T01:12:09Z

CMAKE-FORMAT TEST - PASSED

sst-autotester · 2025-03-06T01:21:36Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

github-actions · 2025-03-06T01:25:16Z

CLANG-FORMAT TEST - FAILED (on last commit):
Run > ./scripts/clang-format-test.sh using clang-format v12 to check formatting

github-actions · 2025-03-06T01:25:20Z

CMAKE-FORMAT TEST - PASSED

github-actions · 2025-03-06T01:29:00Z

CMAKE-FORMAT TEST - PASSED

github-actions · 2025-03-06T01:29:03Z

CLANG-FORMAT TEST - PASSED

sst-autotester · 2025-03-06T23:51:16Z

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed.

sst-autotester · 2025-03-06T23:56:37Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Build Num: 1849
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Build Num: 1805
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Build Num: 1804
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Build Num: 803
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Build Num: 656
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Build Num: 610
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 372
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore

Build Num: 228
Status: STARTED

Using Repos:

Repo: CORE (leekillough/sst-core)

Repo: SQE (sstsimulator/sst-sqe)

Repo: ELEMENTS (sstsimulator/sst-elements)

Repo: MACRO (sstsimulator/sst-macro)

Pull Request Author: leekillough

sst-autotester · 2025-03-07T01:18:51Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Build Num: 1849
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Build Num: 1805
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Build Num: 1804
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Build Num: 803
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Build Num: 656
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Build Num: 610
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 372
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore

Build Num: 228
Status: PASSED

sst-autotester · 2025-03-07T01:19:08Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!

sst-autotester · 2025-03-07T01:19:15Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2025-03-07T05:20:52Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2025-03-07T09:21:02Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2025-03-07T13:50:57Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

berquist

I think separately there should also be a policy on move, now that the copy constructors and assignment are explicitly deleted.

leekillough · 2025-03-07T18:08:30Z

I think separately there should also be a policy on move, now that the copy constructors and assignment are explicitly deleted.

Or, at least, The Rule of 3, or The Rule of 5 if moving is significantly faster than copying (such as if new memory is dynamically allocated during copying but can simply be reused during moving, or if deep copies are expensive while shallow copies just move a few pointers around), or moving is allowed and copying is not, e.g. such as std::unique_ptr.

= default can be used instead of = delete if the behavior of copying, moving or assigning a class member-by-member (including direct bases) is the desired behavior. If the compiler cannot automatically generate copying/ moving/ assignment member-by-member, then explicitly declaring = default will cause a compilation error while leaving = default out will implicitly delete the method without explicitly declaring it = delete, while explicit = delete is preferred.

For C-style structs without explicit constructors, the default behavior can be relied upon without explicitly declaring constructors or assignment operators. The Rule of 3/5/0 says that if you declare one of (copy constructor, copy assignment operator, destructor), you should declare all 3, even if only = default, and if you declare one of (move constructor, move assignment operator), you should declare all 5 of the aforementioned.

sst-autotester · 2025-03-07T19:19:24Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ berquist ]!

sst-autotester · 2025-03-07T19:19:31Z